Closed pcriv closed 10 years ago
copying the fonts to app/assets/fonts seems to solve the issue... but... why? :confused: is the gem missing these fonts? sorry for my lack of understanding on how this works.
@pablocrivella We don't provide those fonts. bootstrap-sass is the one that have them: https://github.com/twbs/bootstrap-sass/blob/115fa1e5338489c312bb7131284d9badd4c18cec/lib/bootstrap-sass/engine.rb#L5
I'll investigate if the version you're using of bootstrap-sass (3.1.1) is having this issue.
If it is of any help, i'm using Rails 4.1 and sass-rails 4.0.3.
The variables.css.scss files of the swatches define:
$icon-font-path: "../fonts/" !default;
comment that line out of the file and the problem is fixed
@esbanarango so changing this line https://github.com/thomaspark/bootswatch/blob/gh-pages/flatly/variables.less#L75 (and for every other bootswatch theme) to use sass-rails font helpers could solve it.
I would change it here: https://github.com/maxim/bootswatch-rails/blob/master/vendor/assets/stylesheets/bootswatch/flatly/_variables.scss#L106 (and all other themes) since this is a rails specific problem. However the "reimport" of bootswatch will break it again.
a better method is to add logic to the converter (https://github.com/maxim/bootswatch-rails/blob/master/converter) to delete this line from the variable files.
I'll see if I can make a pull request to this end later today.
@ahmeij I'll remove that line from all themes and check with the > 3.2 rails versions. If you can add it to the converter and make that PR, it would be great!
Thank you.
Agree with @ahmeij, maybe we should somehow make this document more prominent: https://github.com/maxim/bootswatch-rails/blob/master/CONTRIBUTING.md
@maxim I have an update to the Readme ready, I'll make a pull request once #61 is merged (else I have to branch and rebase, too much effort for a readme ;-))
I'll close this issue as @ahmeij already fix this with #61 PR. Thank you @ahmeij and @pablocrivella. There is a new version of the gem which contains the fix (3.1.1.1).
it works like a charm! thank's @esbanarango and @ahmeij :clap:
framework_and_overrides.css.scss
Gemfile
Full Logs