search

maxim / bootswatch-rails

Bootswatches converted to SCSS ready to use in Rails asset pipeline.
MIT License
489 stars 84 forks source link

Conversion of 3.2.0 less files #62

Closed paul-english closed 10 years ago

paul-english commented 10 years ago

Here's the conversion of 3.2.0 bootswatch files. Do we still need to deal with rearranges? It doesn't seem to give me any useful output on if variables need to be moved. I just get the following for each theme, which doesn't seem to be true.

Swap lines under Variables section due to $gray
Swap lines under Variables section due to $gray
esbanarango commented 10 years ago

@log0ymxm The rearranges method seems to be out of date, but we do need to re-arranges some vars there. Did you test each one of the themes on a Rails app?

paul-english commented 10 years ago

No these haven't been tested yet.

esbanarango commented 10 years ago

@log0ymxm If we're gonna update it to 3.2.0 we also need to update the submodule of 'bootswatch'.

paul-english commented 10 years ago

The submodule has been updated in this PR.

esbanarango commented 10 years ago

@log0ymxm Perfect! So we would need to test the themes. But I think for us (collaborators) it would be better to create branches and then PR from them, so we both can make changes on those branches. What do you think? Would you mind to make these changes in a new branch here?

maxim commented 10 years ago

Hm, did rearranges break? It doesn't do much, just supposed to show that something was used before it was declared, in that case $gray. If it broke would be useful to file a bug…

esbanarango commented 10 years ago

It doesn't do much but what it does is really helpful. But I think it isn't pointing well the variables being used before being declared.

paul-english commented 10 years ago

I pushed to the 3.2.0 branch, I'm closing this PR & will open a bug for 3.2.0 testing.