search

maxim / bootswatch-rails

Bootswatches converted to SCSS ready to use in Rails asset pipeline.
MIT License
489 stars 84 forks source link

Upstream updates #67

Closed ayan4m1 closed 10 years ago

ayan4m1 commented 10 years ago

v3.2.0+2 has added two new themes and a handful of other changes. I have split out the changes that ./rearranges recommended from the others as a separate commit (77e9563) because they seemed a bit spurious to me.

ayan4m1 commented 10 years ago

Looks like paper and sandstone need a little manual cleanup, I can either close this or update it once I have the kinks worked out based on your preference.

esbanarango commented 10 years ago

@ayan4m1 Thank you! Yeah let's make those manual changes and once you think everything is working I'll test and check it to marge.

ayan4m1 commented 10 years ago

Just to leave a note about it somewhere, in 3.2.0+2 upstream seems to have changed the section formatting a bit, from // Section to //== Section and from // ---- to //##. I will add some commits that update rearranges to use some new regex magic.

EDIT: This is why my initial PR was... not working.

ayan4m1 commented 10 years ago

These are working in my testing, but I am not a Ruby guy so I haven't actually used the gem itself. Let me know if I can provide any more info or fixes.

mhodgson commented 10 years ago

Just FYI, there are still a bunch of places in the paper theme using LESS syntax. Some of the uses unfortunately don't have comparable features in sass.

esbanarango commented 10 years ago

@ayan4m1 Could you Re-create this PR and point it to v3.2.0+2 branch instead of master.

ayan4m1 commented 10 years ago

Will do, thanks.