search

maximbaz / arch-secure-boot

UEFI Secure Boot for Arch Linux + btrfs snapshot recovery
ISC License
126 stars 8 forks source link

Confusing name of LTS image when using hardened kernel #10

Closed ShellCode33 closed 1 year ago

ShellCode33 commented 1 year ago

Hey, thanks for this amazing tool ! This is a very small issue, it doesn't have any impact but I thought I would still let you know.

When using a hardened kernel, the recovery EFI image of the LTS kernel will be named secure-boot-linux-hardened-recovery-lts.efi which is a bit confusing because this not a hardened version.

Maybe instead of using $NAME-recovery-lts-unsigned.efi you could hardcode linux-recovery-lts-unsigned.efi ? It would require to change the loop logic though.

https://github.com/maximbaz/arch-secure-boot/blob/4b55a33dd99e13b300efe0e430645ac417b2f58c/arch-secure-boot#L85-L93

maximbaz commented 1 year ago

Thanks for the kind words and the request. I completely agree. I'm not able to test in the near future, but I don't want to hold this back, may I ask you to test #11 and let me know how it went?

ShellCode33 commented 1 year ago

image

Looks fine to me. Though if it were me I would rather name the LTS EFI image secure-boot-linux-lts-recovery.efi for consistence. So that you have linux-hardened-recovery and linux-lts-recovery

maximbaz commented 1 year ago

Once again you are completely right :+1: Thanks for testing! Will get this merged some time tomorrow.

ShellCode33 commented 1 year ago

Great, thanks ! Would be awesome if you could update the AUR package as well