search

maximbaz / rebuild-detector

Detects which Arch Linux packages need to be rebuilt
ISC License
214 stars 11 forks source link

Force use of system binaries/executables #27

Closed MithicSpirit closed 1 year ago

MithicSpirit commented 1 year ago

This fixes an issue I was running into if you have a different version of ghc installed and in your PATH (e.g., with ghcup) where it would give false positives.

I think that a better way to fix this would be to change the logic in order to check what /usr/lib/ghc-* directories are owned by ghc-libs and then checking what packages install to other /usr/lib/ghc-* directories, but that is more work than this.

maximbaz commented 1 year ago

Hey! Thanks for the idea, I think it makes sense to always use system installation. May I ask you to do the same for all other binaries, i.e. do the same for all other places where we currently use command? Not only it might be useful for them too, but also I like to have consistency :grin:

MithicSpirit commented 1 year ago

Good idea, not sure why I didn't think of that. Has been added.