search

maximdeclercq / django-vue

A promising attempt to use VueJS on top of Django.
GNU General Public License v3.0
55 stars 2 forks source link

HTML portion to README #6

Closed christophbrosch closed 3 years ago

christophbrosch commented 3 years ago

Forgot to add the HTML portion to the README.

Added an automatic creation of the tag if it's missing in the template. Ran into this issue while setting everything up on my local machine.

christophbrosch commented 3 years ago

Noticed that @click should actually work if im not mistaken. But it doesn't in the example

maximdeclercq commented 3 years ago

Noticed that @click should actually work if im not mistaken. But it doesn't in the example

BeautifulSoup breaks/removes invalid attributes (starting with @), which is something I'll have to look into. You can use v-on: in the meantime. I have made an issue: #7.

christophbrosch commented 3 years ago

closed this by accident, didn't know forcing my master fork to be your master branch would automatically close an issue related to the changed I made. But can remain closed for now.

maximdeclercq commented 3 years ago

You can always merge my master into your master to sync up (these merge commits normally wouldn't show up in a pull request I think). I also advise you to make some branches on your fork so you don't lose any commits when forcing your master to mine :). Anyway, I actually really liked your original pull request! It was a very good draft and actually helped people to try this repo out who haven't read my Reddit post.