maxime1992 / angular-ngrx-starter

An opiniated Angular setup based on @angular/cli to kickstart an ngrx project
https://maxime1992.github.io/angular-ngrx-starter/
65 stars 8 forks source link

add router-store #19

Open PhilFlash opened 6 years ago

PhilFlash commented 6 years ago

Hi, My PR for router-store Two remarks: . i have downgrade typescript to 2.4.2 (for angular cli) . on my machine, I have errors with prettier:check

yarn run v1.3.2
$ yarn run prettier:base "./{e2e,src}/**/*.{scss,ts}" -l
$ yarn run prettier --single-quote --trailing-comma es5 ./{e2e,src}/**/*.{scss,ts} -l
$ D:\tproj_ang5\angular-ngrx-starter\node_modules\.bin\prettier --single-quote --trailing-comma es5 ./{e2e,src}/**/*.{scss,ts} -l
src\app\core\core.module.ts
src\app\shared\states\root.reducer.ts
src\app\shared\states\router\router.selector.ts
src\styles\shared\_utils.scss
infoerror Visit https://yarnpkg.com/en/docs/cli/run Command failed with exit code 1.
 for documentation about this command.
errorinfo Command failed with exit code 1.
 Visit https://yarnpkg.com/en/docs/cli/runerror for documentation about this command.
 Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! angular-ngrx-starter@0.1.0 prettier:check: `yarn run prettier:base-files -l`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the angular-ngrx-starter@0.1.0 prettier:check script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

A navbar with 2 pages and navigation between these two pages could be an example of navigation with router-store.

maxime1992 commented 6 years ago

Hi @PhilFlash, thanks for making a PR! :)

I'm super busy right now as I'm moving but I do not forget, even if I can take a look only in 2 weeks or a month.

Thanks for reporting the bugs too!