search

maxime1992 / dev-to-git

Publish a blog post (markdown file) to Dev.to from your command line or from CI with this CLI
MIT License
27 stars 13 forks source link

fix(article): only update links for relative images #11

Closed BBlackwo closed 5 years ago

BBlackwo commented 5 years ago

I can't get the tests running locally but I hope this should work.

Should close #10

maxime1992 commented 5 years ago

Thanks for the contribution and the fix @BBlackwo!

I forgot about the tests... I got them to run locally by manually changing the ES6 imports... I do not know how to currently make it work for both the compilation of the lib and the tests.

I've raised an issue on the typescript library starter I've used here https://github.com/alexjoverm/typescript-library-starter/issues/307

If I get an answer soon I'll fix the tests and you'll be able to rebase, otherwise I'll try to run your branch locally but I hope the tests can be fixed and restored on CI :sweat:

So putting that one on hold for a bit, if taking too long I'll check and merge :+1:

maxime1992 commented 5 years ago

Hi @BBlackwo sorry I tried to restored the tests but couldn't manage to make them run correctly yet :(

As your PR is pretty simple I think it should be fine to merge and will proceed :crossed_fingers:

Thanks for your contribution! :clap:

maxime1992 commented 5 years ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: