search

maxime1992 / dev-to-git

Publish a blog post (markdown file) to Dev.to from your command line or from CI with this CLI
MIT License
27 stars 13 forks source link

fix: update PUT body to match forem's API #44

Closed jmcdo29 closed 3 years ago

jmcdo29 commented 3 years ago

The PUT API for updating an article expects an article property on the body that that body_markdown is a part of. This should be a pretty simple API change along with the interface update.

As a side note, I was not able to get tests running locally, but I'll adjust accordingly as I need to from the CI results.

closes #35

jmcdo29 commented 3 years ago

@maxime1992 is there a chance you could allow the CI to run so I can know if I need to update anything? This should be a pretty minimal PR for updating the PUT body

maxime1992 commented 3 years ago

Hi @jmcdo29 :wave:

Thanks for the PR :pray:!

It turns out that Travis was deprecated and doesn't seem to work? Or at least travis.org :thinking: ... So I actually need to fix CI first.

Having a look now, I'll try to have a look at your MR then

maxime1992 commented 3 years ago

I just gave it a go here: https://github.com/maxime1992/dev-to-git/pull/46 :crossed_fingers: it does release to GH pages and npm. Running on master now :)

maxime1992 commented 3 years ago

After some struggle, it's working (Github Actions instead of Travis) :tada:. Looking into your MR now.

maxime1992 commented 3 years ago

~Everything LGTM, could you please rebase?~

EDIT: Nevermind, I think you gave me the rights to edit that MR as I was able to rebase myself :smile_cat:!

maxime1992 commented 3 years ago

Thank you for the PR @jmcdo29 :) nice one

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.4.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: