search

maximebf / atomik

Micro framework for PHP 5.3+ [UNMAINTAINED]
MIT License
46 stars 18 forks source link

Fixes issue #35 #51

Closed JPFrancoia closed 8 years ago

adaniello commented 8 years ago

Only two considerations:

1 - i think that you missed to pass $afterWhere as argument in executeSelect; eg

stmt = $this->executeSelect($tableName, $column, $where, $afterWhere);

2 - in every case, i think that this is useless; with $afterWhere i should pass "after where" arguments to query (eg. "order" and/or "limit"), but with selectValue i get only one column of one record and usually we do it with only "where" condition.

It's my opinion.

JPFrancoia commented 8 years ago

I corrected my PR. But it was useless:

I realized I'm using the release 3.1.5 of atomik (I'm using Atomik in production). As described in #35, there is really a bug in this release. The code has changed in the master branch.

There is no more afterWhere parameter in the function selectValue.

What shall we do with this PR ?

adaniello commented 8 years ago

What shall we do with this PR? I don't know. Maybe close it ;P

JPFrancoia commented 8 years ago

Knew it :) Just in case.