search

maximebf / php-debugbar

Debug bar for PHP
phpdebugbar.com
MIT License
4.2k stars 402 forks source link

Made FontAwesome embedding optional #126

Closed paulofreitas closed 10 years ago

paulofreitas commented 10 years ago

I've noticed that if we use another version of FontAwesome in our project, it gets replaced by php-debugbar's embedded one. Basically it overwrites the path where FontAwesome font will loaded through @font-face rule.

So if we're using a newer version of FontAwesome in our project, all new icons are broken until php-debugbar also update its own FontAwesome bundle.

Ideally we would have an option to didn't embed FontAwesome, leaving that responsibility to our application.

adaniello commented 10 years ago

I had same problem and i solved with include_vendors option: if not set to 'css', no cssVendors ('vendor/font-awesome/css/font-awesome.min.css' and 'vendor/highlightjs/styles/github.css') are included. I hope this can help you.

barryvdh commented 10 years ago

That option is for laravel-debugbar. In the phpdebugbar you can set it using JavascriptRenderer::setIncludeVendors() You can only set the include no vendors, just css, just js or all vendors. http://phpdebugbar.com/docs/rendering.html#assets

Note that you can only use the debug bar assets and manage the dependencies by yourself using $renderer->setIncludeVendors(false). Instead of false, css or js may be used to only include css or js assets of vendors.

paulofreitas commented 10 years ago

Oh I see, that solves the problem. Thank you @barryvdh and @adaniello for pointing this out, was very helpful! :)

My apologies for not having found it before reporting here. I'll be more careful next time.

barryvdh commented 10 years ago

What about changing the font awesome prefix in debugbar to be inside the debugbar css prefix, so it won't conflict with existing installs?

barryvdh commented 10 years ago

And probably need to change the font name also, right?

maximebf commented 10 years ago

changing the prefix and the font name would be tedious. I don't see the problem with just disabling the css vendors and using your own version. font-awesome is not modular so all icons are always included. and even if not included, the debugbar experience is just slightly degraded because of missing icons.