maximegmd / CyberEngineTweaks

Cyberpunk 2077 tweaks, hacks and scripting framework
MIT License
4.48k stars 285 forks source link

Overlay mod bindings and access to mouse/keyboard #957

Open WSSDude opened 1 month ago

WSSDude commented 1 month ago

We disallowed access to keyboard and mouse functions from our fork of sol_ImGui.

I believe, considering ImGui is completely inaccessible from outside of onDraw now, we could reenable keyboard and mouse access to it.

There were few valid requests for such access, like having an ability to have some copy-paste functionality or custom shortcuts while overlay is active.

I would propose reenabling the disabled functions (believe they are just left commented out inside sol_ImGui) and potentially tweaking VKBindings to allow for modbinds separate from in-game ones which would get triggered while overlay to allow for overlay-specific shortcuts.

This could be split into two separate tasks/PRs.

I believe sol_ImGui alone should cover most use-cases, but would need to get properly tested and implemented.

Making the issue so someone can pick it up when they want to. This enhancment would be something that should now be safe and I believe not that hard to implement. Marking it as an enhamcement and good first issue, as I believe it should be quite a small change, at least for the sol_ImGui part.

WSSDude commented 1 month ago

If anyone is willing to pick this up, can provide help as this is something I majorily worked on for CET in the past, know the systems and expected behaviors.

Feel free to contact me.

WSSDude commented 1 month ago

Interesting commit for this task: https://github.com/maximegmd/CyberEngineTweaks/commit/4f23722a5fc68a65c6aa5ef2ac12e0846d9c1164

Everything that was removed by this commit that was under SOL_IMGUI_ENABLE_INPUT_FUNCTIONS should get reverted and retested it is

I suspect 0 to none issues from such partial revert and removal of the define, just dont revert whole commit...