search

maximegmd / CyberEngineTweaks

Cyberpunk 2077 tweaks, hacks and scripting framework
MIT License
4.48k stars 285 forks source link

Added back ImGui MKB Input functions, and added new "Overlay Hotkey" category (Issue #957) #958

Closed justarandomguyintheinternet closed 3 weeks ago

justarandomguyintheinternet commented 1 month ago
WSSDude commented 1 month ago

Will need to have proper look tomorrow but I would want some changes definitely. Overall doesnt seem bad though and seems to cover #957 quite nicely :+1:

WSSDude commented 1 month ago

Do overlay keys not block ImGui input? Was this tested fully? I have a feel it may forbid from typing some letters but yeah, that is one of the things I need to properly "review"... Like if I set some hotkey like A+B, will I still be able to type A+B in ImGui input fields?

And another thing - did you verify that input functions of ImGui are not accessible outside of onDraw right? Think we move whole ImGui table outside of onDraw but better be sure...

Another thing I need to properly look at...

Guess other things will get resolved when you change it according to comments but will write them down tomorrow if they wont change in the meantime.

WSSDude commented 1 month ago

One more note following Discord messages - ImGui keyboard functions may not work with other layout than QWERTY I realised, would need to be checked...

If it doesnt function with other layout, would mark it as limitation for now as Im unsure now if it works with other layouts without changes in imgui_impl/win32.cpp (which this shouldnt touch ideally... that should be left for some other PR if it is an issue...)

justarandomguyintheinternet commented 1 month ago

Do overlay keys not block ImGui input? Was this tested fully? I have a feel it may forbid from typing some letters but yeah, that is one of the things I need to properly "review"... Like if I set some hotkey like A+B, will I still be able to type A+B in ImGui input fields?

And another thing - did you verify that input functions of ImGui are not accessible outside of onDraw right? Think we move whole ImGui table outside of onDraw but better be sure...

Another thing I need to properly look at...

Guess other things will get resolved when you change it according to comments but will write them down tomorrow if they wont change in the meantime.