search

maximegris / angular-electron

Ultra-fast bootstrapping with Angular and Electron :speedboat:
https://www.maximegris.fr/angular-electron/
MIT License
5.67k stars 1.37k forks source link

Electron Builder for windows: Icon Paths Not Translated with Macro in Output Directory #782

Closed AbuDawood closed 1 year ago

AbuDawood commented 1 year ago

Steps to reproduce

use marco pattern in directories "directories": { "output": "releases/${platform}" },

call npm run electron:build in windows host code

the resulted package files are copied into releases/win32 folder however it also create ${platform} and copies .icon-ico folder that contains icon.ico there

✔️ Expected Behavior

${platform} should not created and all the package files must be copied into translated marco that is win32 folder including the .icon-ico

🔍 Additional context

Windows 11 and also tested in docker windows server image

AbuDawood commented 1 year ago

The problem is related to electron-builder bug which they used the pattern directly instead of expanding macro the issue was solved starting from version 24.7.0 NB: do not forget to remove dependencies cache of electron-builder to redownload the compatible dependencies again remove all folders in C:\Users{YOU}\AppData\Local\electron-builder\Cache