search

maximeh / script.myepisodes

Kodi plugin for MyEpisodes.com
GNU General Public License v2.0
10 stars 5 forks source link

Correct fix for Python 3.9 #19

Closed YoYoost closed 2 years ago

YoYoost commented 2 years ago

As mentioned in https://github.com/maximeh/script.myepisodes/pull/18#issuecomment-1191022412 I made a mistake while changing and testing. The original python issue I linked to even mentions CamelCase.

maximeh commented 2 years ago

How did you test in the first place then? To be fair; I didn't and that's my fault.

I wonder if there's any way of having some CI test in place to check theses; I would really like to automate all that stuff; I barely use Kodi theses days myself so it's even more effort to maintain this.

I'll merge + release later today I think.

mkatsevVR commented 2 years ago

I wonder if there's any way of having some CI test in place to check theses

Typechecker could've caught this particular issue, although I'd expect most potential bugs to be related to using external APIs (Kodi and myepisodes) which would require an integration test and likely be rather challenging to setup.

The most practical thing would probably be a high level unit test that relies on mocking the Kodi part.

Then again, with an average of 1 commit per year manual testing is probably the easiest ;)

maximeh commented 2 years ago

That's a good point, and already a good start. I'll look into that, python is not my day to day anymore since a few years; I've lost touch a little bit. Any pointer?

Best,

On Thu, Jul 21, 2022 at 9:12 AM Max Katsev @.***> wrote:

I wonder if there's any way of having some CI test in place to check theses

Typechecker could've caught this particular issue, although I'd expect most potential bugs to be related to using external APIs (Kodi and myepisodes) which would require an integration test and likely rather challenging to setup.

— Reply to this email directly, view it on GitHub https://github.com/maximeh/script.myepisodes/pull/19#issuecomment-1191536315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPCXVBV2ZDUZOCTOW7SYLVVFLD7ANCNFSM54GTSBKA . You are receiving this because you commented.Message ID: <maximeh/script. @.***>

mkatsevVR commented 2 years ago

For typecheck, something like https://github.com/jpetrucciani/mypy-check. Requires annotating types in the existing code to be useful, of course.

For mocks, magicmock probably?

mkatsevVR commented 2 years ago

@maximeh do you need to do anything to publish the update to kodi? https://kodi.tv/addons/matrix/script.myepisodes still shows 3.0.1 as the latest version

maximeh commented 2 years ago

I replied via email but Github doesn't seem to pick it up.

-- Start of the original reply Thanks for pinging me; I forgot to check that it was done.

I have pinged on the PR to merge the update to Kodi: https://github.com/xbmc/repo-scripts/pull/2309

Feel free to add your voice too there :)

maximeh commented 2 years ago

It got approved and merged \o/

I'm still working on the testing part and some refactor too.

maximeh commented 1 year ago

Thanks for pinging me; I forgot to check that it was done.

I have pinged on the PR to merge the update to Kodi: https://github.com/xbmc/repo-scripts/pull/2309

Feel free to add your voice too there :)

Best,

On Tue, Aug 16, 2022 at 2:53 AM Max Katsev @.***> wrote:

@maximeh https://github.com/maximeh do you need to do anything to publish the update to kodi? https://kodi.tv/addons/matrix/script.myepisodes still shows 3.0.1 as the latest version

— Reply to this email directly, view it on GitHub https://github.com/maximeh/script.myepisodes/pull/19#issuecomment-1216026126, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPCXTAQS24I4FAJDEIEXDVZLQ7ZANCNFSM54GTSBKA . You are receiving this because you were mentioned.Message ID: @.***>