maximeh / script.myepisodes

Kodi plugin for MyEpisodes.com
GNU General Public License v2.0
10 stars 5 forks source link

"Marked as watched" stopped working some time ago #20

Closed C4rter closed 2 years ago

C4rter commented 2 years ago

I've noticed that my shows are not marked as watched anymore. I was running the latest version that could be installed via Kodi. Now I've tried out the new 3.0.2 version but no difference.

Is that a known issue? At least one other person I know has the same issue.

maximeh commented 2 years ago

Hi there,

Thanks for your report. I would need some logs ideally to see what's going on with debug enabled. If you could follow what's described here and come back with a log that'd be great: https://kodi.wiki/view/Log_file/Easy

Best,

On Mon, Jul 25, 2022 at 2:46 PM C4rter @.***> wrote:

I've noticed that my shows are not marked as watched anymore. I was running the latest version that could be installed via Kodi. Now I've tried out the new 3.0.2 version but no difference.

Is that a known issue? At least one other person I know has the same issue.

— Reply to this email directly, view it on GitHub https://github.com/maximeh/script.myepisodes/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPCXVRAVWQMVICEGPEXG3VV3VKXANCNFSM54TNZN3Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

C4rter commented 2 years ago

Thanks for the fast reply. Here's my log: http://paste.kodi.tv/epemekuhab

I've activated logging, restarted Kodi and tried to replicate the behavior with an episode of Jackass. I started episode 1, it added the show. I scrolled near to the end. The episode ended. And it did not mark it as watched. Hope the log helps you.

maximeh commented 2 years ago

Thanks for the logs, there's a few logging issues that I need to fix on my end so that's great. The main problem is in the settings, you have set the "Marked as watched from" to 100% (because it's an allowed value and that's probably the mistake here).

2022-07-25 23:06:54.779 T:24043   DEBUG <general>: ### [addon_id] -
[default.py:200 -      onPlayBackEnded() ] __main__: last_pos / total_time
: 1262.4150390625 / 1263.08203125 = 99.94719328032559 %
2022-07-25 23:06:54.779 T:24043   DEBUG <general>: ### [addon_id] -
[default.py:204 -      onPlayBackEnded() ] __main__: min_percent: 100

It's not marked as watched because it's never considered completed.

I would remove the 100% value from the settings, I shouldn't have added that.

Best,

On Mon, Jul 25, 2022 at 4:10 PM C4rter @.***> wrote:

Thanks for the fast reply. Here's my log: http://paste.kodi.tv/epemekuhab

I've activated logging, restarted Kodi and tried to replicate the behavior with an episode of Jackass. I started episode 1, it added the show. I scrolled near to the end. The episode ended. And it did not mark it as watched. Hope the log helps you.

— Reply to this email directly, view it on GitHub https://github.com/maximeh/script.myepisodes/issues/20#issuecomment-1194634035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPCXTTC3LRJLD26AOPHZ3VV37FFANCNFSM54TNZN3Q . You are receiving this because you commented.Message ID: <maximeh/script. @.***>

C4rter commented 2 years ago

Yeah that's it apparently. Thank you. Changed it to 70 (lowest number) and now it worked.