search

maximehamm / tzatziki

Cucumber y Tzatziki
26 stars 7 forks source link

Is there any possible to support deprecated displaying? #5

Closed alaahong closed 3 years ago

alaahong commented 3 years ago

Thanks for your working on such informative tool.

If you had the background of Java, you may know the IntelliJ will display the deprecated method with hyphen image

Do we have any possible to mark the deprecated step definitions as above way? Display in code promotion or feature is fine.

Background, there are multiple step definitions delivered with different version, we have to keep legacy steps for several version but need some ways to mention the deprecated status.

Thanks.

maximehamm commented 3 years ago

Hello Ian

Is this fine for you ?

Sans titre

The color scheme will be up to you :

Sans titre 2

Would you please comment on https://plugins.jetbrains.com/plugin/16289-cucumber-/reviews? I would like to know which part of Cucumber + is most valuable to you :)

Kind regards,

Maxime

alaahong commented 3 years ago

Thanks for you quick response. Will comment on jetbrains later.

In feature is fine, at least user can know the status of used steps.

One further request, do we have the possible to display in code promotion as below place too? image image

maximehamm commented 3 years ago

A will submit a new version 5.1.0 with the "display deprecated step" annotator... I will think about the second feature "display step method as code promotion"... I'm not sure it will be that easy...

maximehamm commented 3 years ago

I fact the "display step method as code promotion" already exists : it is named "Quick definition" and it is available from "View" menu :

image
alaahong commented 3 years ago

I fact the "display step method as code promotion" already exists : it is named "Quick definition" and it is available from "View" menu :

image

Yes，it's a kind of promotion. But as expect, just like the first screenshot, the IntelliJ IDEA can show the deprecated Java method while user typing. Otherwise, while users type in feature, they don't know the deprecated status before step selected as below, there are two methods one is alive, another is deprecated. image image

It doesn't matter if met tech bottleneck on the implementation. It already looks better in feature than previous. Thanks!

maximehamm commented 3 years ago

I took a look: I could hack the thing but it would be really naughty. You have to ask for the evolution of the Gherkin plug-in... at the "CucumberCompletionContributor" class level

alaahong commented 3 years ago

Just try to work with new version Cucumber+ including this function, seems not work yet. Is that based by https://youtrack.jetbrains.com/issue/IDEA-269898 ? image

maximehamm commented 3 years ago

I added a new feature that generated a regression... sorry for that. It will be fixed in next release 5.2.1 of Cucumber+ (The issue you mention is indeed the reason for this regression. The new feature (5.2.0) consists in allowing to navigate to the latest known implementation of a feature even when changing the wording of this feature in Gerkin file) The 5.2.1 release should be available in few hours or tomorrow.

alaahong commented 3 years ago

The 5.2.1 is fine now, thanks!

maximehamm commented 3 years ago

Hi Ian I would be happy if you could rate cucumber+ at Intellij Market place ! Tell us why Cucumer+ is good for you ? https://plugins.jetbrains.com/plugin/16289-cucumber-

maximehamm commented 3 years ago

Hello FYI : The next version will allow better completion! And it will display deprecated steps in a crossed out way ! I'm working also on "code promotion" as you were requested... but not sure it is allowed !

image
maximehamm commented 3 years ago

Code promotion is available also ! Let's press "ALT-Space" when the completion popup is available : image