search

maximelafarie / ngx-smart-modal

Modal/Dialog component crafted for Angular (Ivy-compatible)
https://maximelafarie.com/ngx-smart-modal/
MIT License
323 stars 87 forks source link

Backdrop is accessible by navigating using tabs though modal is open. #192

Closed lokeshreddy1706 closed 4 years ago

lokeshreddy1706 commented 5 years ago

I'm submitting an issue (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting

Current behavior Even though [backdrop] parameter is provided, when the modal popup is open, we are able to access backdrop by clicking tabs.

Expected behavior Backdrop can't be accessible which clicking on tabs. The focus should move to the modal instead of the backdrop

Reproduction of the problem

  1. Open any modal
  2. click tabs multiple times until navigation goes to the backdrop

<ngx-smart-modal [closable]="false" [backdrop]="true" identifier="sampleModal">

What is the motivation/use case for changing the behavior? To deliver the best quality product

Please tell us about your environment: All

maximelafarie commented 5 years ago

Hi @lokeshreddy1706 and thank you for this well-detailed issue.

Indeed, it seems it's an accessibility bug and we should fix it asap. We need to make backdrop excluded from browser-readable elements to avoid it to be selected.

I'm pushing this issue into our roadmap. I have good hope to fix that in our next incoming minor release.

Stay tuned!

Cheers! 🖖

maximelafarie commented 4 years ago

Closed by #238! 🎉🖖