maximelafarie / ngx-smart-modal

Modal/Dialog component crafted for Angular (Ivy-compatible)
https://maximelafarie.com/ngx-smart-modal/
MIT License
323 stars 87 forks source link

Angular 10 Ivy Issue #301

Open hypertextdevelopers opened 4 years ago

hypertextdevelopers commented 4 years ago

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

I get this error "This likely means that the library (ngx-smart-modal) which declares NgxSmartModalModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy. " the time I try to run ngx-smart-modal in Angular 10. Expected behavior

Ngx-smart-modal should have support for Angular 10 Reproduction of the problem

What is the motivation / use case for changing the behavior?

Being up to date with Angular versions Please tell us about your environment:

OS Catalina, PHPStorm, Yarn

KiranShakya commented 4 years ago

ERROR: node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:6:23 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s).

6 static forRoot(): ModuleWithProviders;

node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:10:24 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s).

10 static forChild(): ModuleWithProviders;

These are two things I see when trying to build with this dependency. Previous Angular versions didn't require type definition for ModuleWithProviders. Hope this info is helpful for creating an Angular Ivy compatible release.

senzacionale commented 4 years ago

Same problem. Any update when new release will be available for Angular 10?