feat: angular-ivy-compliant refactoring - Githubissues

maximelafarie / ngx-smart-modal

Modal/Dialog component crafted for Angular (Ivy-compatible)

https://maximelafarie.com/ngx-smart-modal/

MIT License

325 stars 85 forks source link

feat: angular-ivy-compliant refactoring #376

Closed maximelafarie closed 1 year ago

maximelafarie commented 1 year ago

fixes #310
fixes #375

TASKS:

[x] Make the lib angular-ivy-compliant
[x] Make the test pass
[x] Remove commented test blocks
[x] Update readme
[x] Add Github Actions routines (at least for lint and tests)
[x] Remove / update all previous CI routines links (travis, codacy, etc.)

NOT MANDATORY TASKS:

[ ] Add package publish automation (with Github Actions)
[ ] Update the demo (with Angular 16)
[ ] Add external documentation (with Docusaurus)
[ ] Project cleanup (remove uselessly nested folders, etc.)
[ ] Update changelog

maximelafarie commented 1 year ago

Thank you @khylias for keeping an eye on this! 🙏 I've done an implementation test here and will merge this branch as 14.0.2 has been released on npm. I won't require someone to full review this as the whole code has been refactored and it may take a lot of time. However, I could use some help with feedback on version 14!