search

maximelafarie / ngx-smart-modal

Modal/Dialog component crafted for Angular (Ivy-compatible)
https://maximelafarie.com/ngx-smart-modal/
MIT License
325 stars 85 forks source link

Fix/issue 379 #380

Closed AntLer-24rus closed 10 months ago

AntLer-24rus commented 10 months ago

@maximelafarie, hello!

I think I have solved the problem described in issued #379. In the test environment, at first glance, everything works correctly. The angular version was also raised to 16 and the expectations in the tests were slightly added. This library is very important to me, two large projects depend on it and I would not like to switch to something else.

If possible, I ask you to conduct a review and include changes in the production build. Thank you in advance!

close #379

maximelafarie commented 10 months ago

Also thank you @mohsen-amani for pre-approving