search

maximelebreton / quick-javascript-switcher

A Chrome Extension to enable / disable javascript 'on the fly'
https://chrome.google.com/webstore/detail/geddoclleiomckbhadiaipdggiiccfje
251 stars 49 forks source link

Color blind friendly icon? #37

Open ascendbruce opened 5 years ago

ascendbruce commented 5 years ago

Hi @maximelebreton, just saw your crowdfunding campaign, supported immediately. Thanks for making this super useful extension.

However, I wonder if you consider adding (maybe configurable?) on/off labels in the toggle icon?

Example: iPhone's Settings app > General > Accessibility > On/Off Labels

img_0658

maximelebreton commented 5 years ago

@ascendbruce yep, it's possible with a badge (on/off) text on the browser action (https://developer.chrome.com/extensions/browserAction#method-setBadgeText)

would this render be suitable?

maximelebreton commented 5 years ago

And just for asking, I suppose the toggle position is not enough? https://github.com/maximelebreton/quick-javascript-switcher/issues/1

ascendbruce commented 5 years ago

@maximelebreton In fact, I don't know. I have normal vision. Brought this up because I recently read some stories about this. Thought it could be a nice enhancement.

I set my display to greyscale to "simulate", and the new design is still sort of hard to tell (other than the toggle position).

But you probably want to gather more feedbacks about this. Thanks again for everything you have done!

perpetual-hydrofoil commented 5 years ago

In the current icon, the color doesn't just change -- it also moves from the top left to bottom left. It's not extremely obvious, but it works. As long as you do something like that in the new icon (changing the shape or layout of the toggle/icon), it should be good.