Hotkey Ctrl-w collides with browser default

maximelebreton / quick-javascript-switcher

A Chrome Extension to enable / disable javascript 'on the fly'

https://chrome.google.com/webstore/detail/geddoclleiomckbhadiaipdggiiccfje

251 stars 49 forks source link

Hotkey Ctrl-w collides with browser default #42

Closed mmmmgh closed 3 years ago

mmmmgh commented 4 years ago

It is nice to have a JS toggle hotkey. However the current one (ctrl-w) collides with the browser's hotkey for closing the current window which I happen to use regularly.

Therefore: Can we have a configurable hotkey for this extension?

PS: I just discovered your extension and like it very much for its site-specific Javascript handling!

cirosantilli commented 3 years ago

Where is that hotkey documented/coded BTW?

maximelebreton commented 3 years ago

Hey @cirosantilli, you can find the default shortcut in the manifest.json, and customize it, but yeah you're right, i've never documented it, so I just updated the readme, thanks for the report!

cirosantilli commented 3 years ago

Nice! Make sure to also show it on the extension page: https://chrome.google.com/webstore/detail/quick-javascript-switcher/geddoclleiomckbhadiaipdggiiccfje Thanks for this Maxim.