search

maximepvrt / angular-google-gapi

An AngularJS module for using all Google Apis and your Google Cloud Endpoints (Google App Engine) with OAuth. This module uses Google APIs Client Library for JavaScript, available for all GApis.
176 stars 111 forks source link

Autentication should implement new API gapi.auth2 #40

Open fernando-lopez opened 9 years ago

fernando-lopez commented 9 years ago

Google has recently updated the API Sign-in Libraries. It should be replaced by the currently used in the project

More details here https://developers.google.com/identity/sign-in/web/reference

maximepvrt commented 8 years ago

I look that soon. If you you want, you can add this with a pull request

fernando-lopez commented 8 years ago

@maximepvrt do you have in mind update the library to oauth 2.0?

The library auth is already deprecated https://developers.google.com/api-client-library/javascript/reference/referencedocs#gapiauthauthorizeparams--------callback

There is a risk to impact the apps using this project in case Google disable the library.

EugeneZ commented 7 years ago

Something to be aware of: The new gapi.auth2 API does not work when the "third party cookies" checkbox in Chrome is ticked, nor in Safari or Chrome's Private Browsing mode, or any other system where third party use of sessionStorage is limited. They have no plans to fix this. So if you upgrade it could actually cause more problems.

google/google-api-javascript-client#246

lukewlms commented 7 years ago

@EugeneZ Thanks for the info. This seems crazy. Disabling third party cookies is a recommended privacy practice.

EugeneZ commented 7 years ago

@lukecwilliams It looks like they might be fixing it, maybe. In the meantime, I have replaced all use of GAPI's javascript client with regular OAuth and REST libraries.

lukewlms commented 7 years ago

@EugeneZ Thanks for the response. We are rolling back the effort to use pop-up authentication, and implementing only the Authentication URL version.