search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
102 stars 40 forks source link

For marker genes, p-values in scientific notation not correctly sorted #110

Open matthewspeir opened 5 years ago

matthewspeir commented 5 years ago

If you have p-values, or really any value in scientific notation, in the marker genes pop-up, the numbers aren't properly sorted. See marker genes for this dataset: https://cells.ucsc.edu/?ds=mouse-organogenesis

maximilianh commented 5 years ago

I think the default sort order is not OK, it's only off if you re-sort yourself when clicking on the column header. Is this correct?

On Mon, May 20, 2019 at 8:02 PM Matt Speir notifications@github.com wrote:

If you have p-values, or really any value in scientific notation, in the marker genes pop-up, the numbers aren't properly sorted. See marker genes for this dataset: https://hgwdev.gi.ucsc.edu/~mspeir/cb_mouse_organogenesis/?ds=mouse-organogenesis

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

matthewspeir commented 5 years ago

Yeah, I think that's correct. Though another weird thing I just noticed about that mouse-organogenesis dataset is that there are some marker genes with pval/qval == 0 which all show up at the top. I would have expect those to show up at the bottom? Or maybe I should just remove those from the file altogether?

maximilianh commented 5 years ago

No 0 is at the top, it goes from lowest to highest p-value.

On Tue 21 May 2019 at 19:16, Matt Speir notifications@github.com wrote:

Yeah, I think that's correct. Though another weird thing I just noticed about that mouse-organogenesis dataset is that there are some marker genes with pval/qval == 0 which all show up at the top. I would have expect those to show up at the bottom? Or maybe I should just remove those from the file altogether?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/110?email_source=notifications&email_token=AACL4TKDQJROOWRUKU5HGWDPWQU7XA5CNFSM4HOEGOFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV4SWMA#issuecomment-494480176, or mute the thread https://github.com/notifications/unsubscribe-auth/AACL4TOKLZ67MAQAXHRJYSTPWQU7XANCNFSM4HOEGOFA .

matthewspeir commented 5 years ago

Ah. Yeah, you're right.

maximilianh commented 5 years ago

And you’re right that a p value of 0 is very strange but scientists love low p values ...

On Tue 21 May 2019 at 20:49, Matt Speir notifications@github.com wrote:

Ah. Yeah, you're right.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/110?email_source=notifications&email_token=AACL4TLOP2V3ISJSTAWY333PWQ74JA5CNFSM4HOEGOFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV42UVQ#issuecomment-494512726, or mute the thread https://github.com/notifications/unsubscribe-auth/AACL4TPBLIZ5XIZ4ML2FTYDPWQ74JANCNFSM4HOEGOFA .