search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

Group select in legend #111

Closed matthewspeir closed 2 years ago

matthewspeir commented 5 years ago

At the recent Bay Area Stem Cell Conference, someone requested to be able to select groups in the legend and change the color of multiple groups simultaneously. They were using the color change to hide groups of cells.

maximilianh commented 5 years ago

You can already select multiple groups, by using shift. Should we have checkboxes for that... ? Loupe does that.

I used to have Edit > Hide. I could revive it.

On Thu, May 23, 2019 at 5:55 PM Matt Speir notifications@github.com wrote:

At the recent Bay Area Stem Cell Conference, someone requested to be able to select groups in the legend and change the color of multiple groups simultaneously. They were using the color change to hide groups of cells.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/111?email_source=notifications&email_token=AACL4TMABLPHT3V6IYWIGNTPW247DA5CNFSM4HPH7J72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVQBPTQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AACL4TPHSQH4NCTIHBGOXATPW247DANCNFSM4HPH7J7Q .

maximilianh commented 5 years ago

This has come up before, both Lucas Schirmer and Dmitry from UCSF have had the same problem. most people don't know about shift-click in Windows or OSX.

Adding little checkboxes would cost me 7pixels, but maybe that's worth it? They say it's a pretty common operation. This would also make it more obvious that people can do something in the legend. Also, Loupe does it. So I guess it's a go?

On Fri, May 24, 2019 at 3:44 PM Maximilian Haeussler maximilianh@gmail.com wrote:

You can already select multiple groups, by using shift. Should we have checkboxes for that... ? Loupe does that.

I used to have Edit > Hide. I could revive it.

On Thu, May 23, 2019 at 5:55 PM Matt Speir notifications@github.com wrote:

At the recent Bay Area Stem Cell Conference, someone requested to be able to select groups in the legend and change the color of multiple groups simultaneously. They were using the color change to hide groups of cells.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/111?email_source=notifications&email_token=AACL4TMABLPHT3V6IYWIGNTPW247DA5CNFSM4HPH7J72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVQBPTQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AACL4TPHSQH4NCTIHBGOXATPW247DANCNFSM4HPH7J7Q .

maximilianh commented 5 years ago

Do you think the checkboxes should be rather on the left or on the right? If left, before or after the color picker boxes?

On Fri, May 24, 2019 at 4:20 PM Maximilian Haeussler maximilianh@gmail.com wrote:

This has come up before, both Lucas Schirmer and Dmitry from UCSF have had the same problem. most people don't know about shift-click in Windows or OSX.

Adding little checkboxes would cost me 7pixels, but maybe that's worth it? They say it's a pretty common operation. This would also make it more obvious that people can do something in the legend. Also, Loupe does it. So I guess it's a go?

On Fri, May 24, 2019 at 3:44 PM Maximilian Haeussler < maximilianh@gmail.com> wrote:

You can already select multiple groups, by using shift. Should we have checkboxes for that... ? Loupe does that.

I used to have Edit > Hide. I could revive it.

On Thu, May 23, 2019 at 5:55 PM Matt Speir notifications@github.com wrote:

At the recent Bay Area Stem Cell Conference, someone requested to be able to select groups in the legend and change the color of multiple groups simultaneously. They were using the color change to hide groups of cells.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/111?email_source=notifications&email_token=AACL4TMABLPHT3V6IYWIGNTPW247DA5CNFSM4HPH7J72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVQBPTQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AACL4TPHSQH4NCTIHBGOXATPW247DANCNFSM4HPH7J7Q .

matthewspeir commented 5 years ago

Haha, it was actually someone from the Kriegstein lab at UCSF that suggested it.

Can I see what it looks like on the left, before the color picker boxes? I feel like checkboxes are usually on the left side of their label, so let's go with that. This UX stackexchange thread seems to say the same, though there can obviously exceptions: https://ux.stackexchange.com/questions/5080/should-checkbox-labels-be-to-the-right-or-the-left.

matthewspeir commented 4 years ago

I see that the checkboxes are now in place on cells-test, but it would be great to also see the "Hide selected cells" return as I know it was requested by someone in #30.

matthewspeir commented 2 years ago

Not sure why this is still open, so closing.