maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

sample points split by edges when zoomed 100% #13

Closed hbeale closed 6 years ago

hbeale commented 6 years ago

edited to split issues: some samples are still half cut-off at 100%, example of half cut-off point on left, below.

image

maximilianh commented 6 years ago

I guess what you really want is a 5px border at the edges? In this way, nothing will ever be cut off?

hbeale commented 6 years ago

Yes, that would solve the problem of partial points, i'm guessing. But I'd also like to be able to zoom out further, like to the following and even further. In this screenshot, the image is really only taking up ~75 pct of the screen so you can have the "30k foot view". Do you want me to make it a separate issue?

image

maximilianh commented 6 years ago

It sounds like a new ticket, yes.

Also, it sounds like I'll need a zoom out button at least. Hitting it repeatedly would zoom out more and more. I see no other way how to implement this. Do you?

On Fri, Oct 20, 2017 at 4:40 PM, hbeale notifications@github.com wrote:

Yes, that would solve the problem of partial points, i'm guessing. But I'd also like to be able to zoom out further, like to the following and even further. In this screenshot, the image is really only taking up ~75 pct of the screen so you can have the "30k foot view". Do you want me to make it a separate issue?

[image: image] https://user-images.githubusercontent.com/54659/31845391-ff341180-b5b4-11e7-8003-f62551bca8ce.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/13#issuecomment-338345906, or mute the thread https://github.com/notifications/unsubscribe-auth/AAS-TSIsRqcYLfv0zdYpKbrInsf32e8Mks5suS9rgaJpZM4QBSvR .

maximilianh commented 6 years ago

I wonder if the new zoom buttons solved this problem?

hbeale commented 6 years ago

Super!