search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
102 stars 40 forks source link

Custom annotations improvements #135

Open matthewspeir opened 4 years ago

matthewspeir commented 4 years ago

Custom annotations are great, though there are a few things that could be changed to greatly improve them:

  1. Allow for users to specify more than one custom annotation field. Right now, if you try to add a new field name in the 'Name of annotation field' box after having previously added one, it ignores what you put into the box and shoves your new annotation into the previously specified field.
  2. Related to (1), if users are allowed to have multiple custom annotation fields, it would be great if previous fields were available in some kind of drop-down or checkbox menu, so that users didn't have to remember exactly how they entered a custom field name the first time.
  3. As you add custom annotations to a field, the colors for previously added annotations change. It would be great if adding new annotations didn't change the color of previously added annotations. Not a huge deal, but it was a bit confusing when I encountered this.
amisharin commented 4 years ago

These are great suggestions! To extend on them: it'd be nice to link these user-provided custom annotations to some sort of wiki-interface or disc.us platform, so people can compare their annotations.

maximilianh commented 4 years ago

I totally agree, and thanks to both of you, but I really struggle to get some vision of how this would work. You would need a login (username/password) on some platform. Then you'd save your annotations into this system. At some point, you'd publish your annotations by clicking a checkbox. And then I'd need some user interface so you can load annotations that other people have published. Is this roughly what you have in mind?

On Sun, Oct 13, 2019 at 3:34 PM Alexander Misharin notifications@github.com wrote:

These are great suggestions! To extend on them: it'd be nice to link these user-provided custom annotations to some sort of wiki-interface or disc.us platform, so people can compare their annotations.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/135?email_source=notifications&email_token=AACL4TLX5JZFNXOPRFU7ZYDQOMPUVA5CNFSM4I44GXW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCWMBA#issuecomment-541419012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TLAATMH4TFBR2ZM5QLQOMPUVANCNFSM4I44GXWQ .

matthewspeir commented 4 years ago

Interesting idea. I hadn't thought linking up to a site for sharing custom annotations.

@maximilianh what are your thoughts about the 3 suggestions I put forward in the initial description of this ticket? Are those feasible to implement?

maximilianh commented 4 years ago

Your three suggestions are spot-on. I'd love to implement them right away, but I'm stuck in this grant writing thing...

On Thu, Oct 17, 2019 at 10:21 AM Matt Speir notifications@github.com wrote:

Interesting idea. I hadn't thought linking up to a site for sharing custom annotations.

@maximilianh https://github.com/maximilianh what are your thoughts about the 3 suggestions I put forward in the initial description of this ticket? Are those feasible to implement?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/135?email_source=notifications&email_token=AACL4TI4FVO2LWAS7YAH2K3QPAOBXA5CNFSM4I44GXW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBPH34I#issuecomment-543063537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TNZTZNOYR6BXUTCF6TQPAOBXANCNFSM4I44GXWQ .