search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
105 stars 42 forks source link

Change label font #145

Closed mxposed closed 3 years ago

mxposed commented 5 years ago

Custom font for labels with a preloader div in main html (a bit dirty…) The font files are originally from google fonts

maximilianh commented 5 years ago

@matthewspeir didn't like the font a lot... Hey Matt, any other ideas on the font issue?

matthewspeir commented 5 years ago

I'm a little torn. I think this new font is great when zoomed out and looking at large regions (better than the old font), however, when you start to zoom on a single cluster (e.g. AT1) or further it starts to look a little weird. Like it's getting smaller than it should. Not really sure how to describe it.

maximilianh commented 5 years ago

Hmmm.... the font shouldn't' zoom at al. Usually the font is just placed at a fixed size. The size shouldn't change...

mxposed commented 5 years ago

This font might not be ideal, but I guess it's still a good idea to move from default bold sans-serif. I can take any other font from Google fonts and put it in this pull request or even try to make it configurable. As for zoom: fonts do not zoom, they stay at fixed size, but I get what you mean @matthewspeir

maximilianh commented 5 years ago

I agree that anything is better than the default font, in bold.

It’s getting smaller than it should ?

On Thu 17 Oct 2019 at 21:43, Nikolay Markov notifications@github.com wrote:

This font might not be ideal, but I guess it's still a good idea to move from default bold sans-serif. I can take any other font from Google fonts and put it in this pull request or even try to make it configurable. As for zoom: fonts do not zoom, they stay at fixed size, but I get what you mean @matthewspeir https://github.com/matthewspeir

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/145?email_source=notifications&email_token=AACL4TJVQOG44EBQSUFA4PDQPC56JA5CNFSM4JAS2OF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBRJLKY#issuecomment-543331755, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TOQV5QTMBS7N2WF4V3QPC56JANCNFSM4JAS2OFQ .

matthewspeir commented 5 years ago

Oh yeah, I didn't think the font itself was zooming, it's more that when you zoom in something about the font feels off in comparison to the old one.

Either way, I would say just merge this in. We can always change the font again if others complain

Here are a couple of images comparing what the font looks like when you've zoomed in: cellbrowserOldFont cellbrowserNewFont

maximilianh commented 5 years ago

Ahh! I see what you mean Matt!

So the new font is better, we all agree on that, but it's hard to see on darker background. I think this is because a) the font is thinner and b) Nikolai removed the drop shadow. The drop shadow was there to make the font stand out on dark background. Dark background is only there a lot when you zoom in.

Hey Nikolai, why did you remove the drop shadow?

Did you try to make the font a bit bigger or thicker to make it stand out more?

mxposed commented 5 years ago

I thought that the strokeStyle was already providing the same thing as text shadow, so I removed it. And I also tried to make it smaller. That's just how it felt to me.

I can restore text shadow and try other things too

maximilianh commented 5 years ago

Its similar to the shadow but since it’s thinner, I think it explains Matt’s observation that on dark background it’s a lot harder to read...

On Mon 21 Oct 2019 at 19:03, Nikolay Markov notifications@github.com wrote:

I thought that the strokeStyle was already providing the same thing as text shadow, so I removed it. And I also tried to make it smaller. That's just how it felt to me.

I can restore text shadow and try other things too

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/145?email_source=notifications&email_token=AACL4TLZWBAEOJJNL3MYWKDQPXOFDA5CNFSM4JAS2OF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB3BT2I#issuecomment-544610793, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TNS4BAZ4MLYUHFACPLQPXOFDANCNFSM4JAS2OFQ .