Closed mxposed closed 4 years ago
Great thanks! Yes, I've replaced my stupid csv parser with the Python one in 1-2 other places, but this change is good, too. (BTW: a cluster with commas in it?)
Yes, we got into a habit of naming clusters like "CellType, Marker", for instance "AM, FOLR3"
I see! I'll be more careful with csv parsing from now on...
On Wed, Apr 22, 2020 at 7:11 PM Nikolay Markov notifications@github.com wrote:
Yes, we got into a habit of naming clusters like "CellType, Marker", for instance "AM, FOLR3"
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/168#issuecomment-617910959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TJZAQ26XCK6ZB3SPLLRN4QLPANCNFSM4MMZOMZA .
This is why we always and only use .tsv files...
On Wed, Apr 22, 2020 at 7:18 PM Maximilian Haeussler maximilianh@gmail.com wrote:
I see! I'll be more careful with csv parsing from now on...
On Wed, Apr 22, 2020 at 7:11 PM Nikolay Markov notifications@github.com wrote:
Yes, we got into a habit of naming clusters like "CellType, Marker", for instance "AM, FOLR3"
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/168#issuecomment-617910959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TJZAQ26XCK6ZB3SPLLRN4QLPANCNFSM4MMZOMZA .
Since we have clusters with commas, and since this markers parsing code does not really follow the
csv
format, I thought I'd improve it. Probably, this is not the only place that needs change if I really want to have cluster names with commas, but it's the first one that broke down : )