search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

Marker gene box is not closable by Esc #176

Closed mxposed closed 3 years ago

mxposed commented 4 years ago

After the markers data is loaded via ajax, you build the table and then explicitly remove the focus from the current object (https://github.com/maximilianh/cellBrowser/blob/master/src/cbPyLib/cellbrowser/cbWeb/js/cellBrowser.js#L6192) preventing the dialog box to close on Esc.

Is it intended, why?

maximilianh commented 4 years ago

Oh... this is because the current object was not the dialog but the dataset list. I'll need to focus on the dialog. thanks!

On Fri, May 22, 2020 at 12:05 AM Nikolay Markov notifications@github.com wrote:

After the markers data is loaded via ajax, you build the table and then explicitly remove the focus from the current object ( https://github.com/maximilianh/cellBrowser/blob/master/src/cbPyLib/cellbrowser/cbWeb/js/cellBrowser.js#L6192) preventing the dialog box to close on Esc.

Is it intended, why?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TNIZWUWSS6HSTYAKULRSWQT3ANCNFSM4NHG755Q .

mxposed commented 4 years ago

I can send you a pull request with this line removed if you want

maximilianh commented 4 years ago

Hm, do you remember if did we end up doing this? If yes, we can close the ticket...

mxposed commented 4 years ago

No, we haven't done this yet

maximilianh commented 3 years ago

Thanks!