maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

Fix tooltip update on select changes #181

Closed mxposed closed 4 years ago

mxposed commented 4 years ago

In this commit https://github.com/maximilianh/cellBrowser/commit/313a969831fc140b9c06ad88c2dfcf883d0ad289#diff-fabc9ba7f3a30426c8a51d67788c32dbR5185

I introduced a bug: when selection changes, it tries to update the tooltip label, and if label wasn't ready yet, then $tip would be undefined and the code gave an exception. Now I explicitly check if $tip is ready.