maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

select cells based on intersection of annotations #191

Closed Gibbsdavidl closed 3 years ago

Gibbsdavidl commented 3 years ago

Is this possible? It's essentially making cell selections based on annotation set operations.

I want to select a set of cells within cluster A as background (param == 'X', cluster=='A'), and compare to the remaining cells within cluster A (param != 'X' and cluster =='A' or even param == 'Y').

Thanks!

maximilianh commented 3 years ago

Did you try Edit - Find Cells ?

On Mon, Sep 28, 2020 at 10:11 PM David L Gibbs notifications@github.com wrote:

Is this possible? It's essentially making cell selections based on annotation set operations.

I want to select a set of cells within cluster A as background (param == 'X', cluster=='A'), and compare to the remaining cells within cluster A (param != 'X' and cluster =='A' or even param == 'Y').

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/191, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TNXEBMH2QXOO6P7Q33SIDUW3ANCNFSM4R45ZDVQ .

Gibbsdavidl commented 3 years ago

Oh wow! Thanks. That's just what I was looking for.

-dave

Gibbsdavidl commented 3 years ago

One suggestion is to have a 'is not equal to' selection for enumerated types.

maximilianh commented 3 years ago

I'm glad you asked. It's very hard to get an idea for me which features people find useful...

On Tue, Sep 29, 2020 at 12:59 AM David L Gibbs notifications@github.com wrote:

One suggestion is to have a 'is not equal to' selection for enumerated types.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/191#issuecomment-700326654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TJZNQLV6RUHZYJEA5DSIEINFANCNFSM4R45ZDVQ .

Gibbsdavidl commented 3 years ago

Actually, this would be super useful feature for me... so I'm going to reopen the issue. :-) Hope that's OK.

I have a cluster where cells are annotated with 4 categories (A,B,C,D) and if you want to select category A, it's pretty easy (select cells: cluster == 1, category == A). But if you want to compare A vs others, it's more difficult (cluster == 1, category != A).

Thanks! -dave

maximilianh commented 3 years ago

Isn’t there a “is not equal” operator ? Oh... did I forget to add that ???

On Tue 29 Sep 2020 at 20:23, David L Gibbs notifications@github.com wrote:

Actually, this would be super useful feature for me... so I'm going to reopen the issue. :-) Hope that's OK.

I have a cluster where cells are annotated with 4 categories (A,B,C,D) and if you want to select category A,

it's pretty easy (select cells: cluster == 1, category == A). But if you want to compare A vs others, it's

more difficult (cluster == 1, category != A).

Thanks!

-dave

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/191#issuecomment-700896345, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TO7R6XYFMDLVUM5GZTSIIQ2RANCNFSM4R45ZDVQ .

Gibbsdavidl commented 3 years ago

Oh, uh, yes. There is not an "is not equal" (!=) operator.

-dave

maximilianh commented 3 years ago

Oops, sorry. I've added it now, you can find it on the Github develop branch and also on cells-test.gi.ucsc.edu. Is this for your own cell browser installation? Or for a dataset on cells.ucsc.edu ?

Also, I'd love to understand better the use case: is this for comparing two non-clusters?

@matthewspeir since we've covered it here, not sure, but maybe we need an internal redmine ticket for it, too? I don't remember what our plan was for handling Github issues w/r to releases.

matthewspeir commented 3 years ago

I believe this has made it into a release. Closing for now.