maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

UTF8 in metadata fields doesn't work #199

Closed mxposed closed 3 years ago

mxposed commented 3 years ago

Hey!

I've recently had UTF-8 character in metadata (en-dash instead of minus sign), and cellbrowser didn't handle it well. When this part of metadata was loaded on cell hover, there were alerts, and also in the legend on the right the values were not displayed correctly (see screenshot).

Screen Shot 2020-12-19 at 19 53 21

maximilianh commented 3 years ago

Ah nice, we've never had utf8 yet. Yes, my way of getting the size was wrong. Thanks!

matthewspeir commented 3 years ago

Nice, we can update the label field for this dataset whenever this makes it out to the main site: https://cells-test.gi.ucsc.edu/?ds=covid19atlas+c19a-park20&meta=Anno_level_fig1. I have to switch it to the BroadCellType field when I wrangled the dataset since we didn't support utf8 yet.