maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

A bunch of small fixes and improvements #203

Closed mxposed closed 3 years ago

mxposed commented 3 years ago

Hi! I went over some of the things I had in mind, here's the list: — stripped trailing whitespace from js files (sorry, my editor does that automatically) — top right “Select all” checkbox now selects all cells, instead of just visible cells — in left panel the helper text “Hover over a cell to update data below” or “Cells selected. No update on hover.” now switches immediately when something is selected or deselected — bins for numbers are now formatted as “0.24–9.87” instead of ”0.24 - 9.87” — when you mouseout from hovered metadata field on the right, the hover status now disappears  — for numeric metadata fields hover histogram summary is not sorted by frequency (shows distribution better) — display summary stats for metadata fields on selection (brought back), for numberic fields display mean + sd (instead of most frequent bin) — select cluster cells on alt+click on cluser name, add those cells to selection on shift+click

You can look at cellbrowser with those changes here: https://mxposed.github.io/cellBrowser/

Each change is in it's own commit, I can separate things if you want some changes, but not others.

Let me know what you think.

maximilianh commented 3 years ago

This looks all good. Great ideas. Any idea how we could document the alt+click? maybe on the mouseover text itself?

mxposed commented 3 years ago

Yes, I put a text about alt-click in the mouseover popup.

maximilianh commented 3 years ago

Duh - I looked at that commit but skipped over the text. Thanks!!