Show pct of category in meta histogram

[mxposed]

When you hover on a meta field with selection, it shows percentage of a given category that is selected after each category.

For instance:

So that you know not only how the selected cells distribute over this field, but also which proportion of those categories are covered

[maximilianh]

This makes a lot of sense.

Is it obvious to the user what "it" means here? Maybe we could spell out the meaning? Hmmm....

[mxposed]

Change the PR to point to develop.

I couldn't come up with a better phrasing, but I agree, it sounds strange right now. Do you have an idea how to spell it out? ”Of this category”?

[matthewspeir]

Hmm, I feel like being specific here would be better. I'm not sure I understand what "it" is, at least not without having to think about what it might be.

For example, in the image you shared, 78% of the selected cells have the value "Cortex", but 37.7 of "it" (where "it" is all cells) have the value "Cortex"?

On Mon, Jan 4, 2021 at 9:13 AM Nikolay Markov notifications@github.com wrote:

Change the PR to point to develop.

I couldn't come up with a better phrasing, but I agree, it sounds strange right now. Do you have an idea how to spell it out? ”Of this category”?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/205#issuecomment-754100118, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACX2BZXKWUNR56AWRDHXSC3SYHZLBANCNFSM4VNYFRIA .

[mxposed]

Yes, you're right, in the image above it says that 78% of selected cells have the value “Cortex”, and those 78% constitute 37.7% of all cells with the value “Cortex”.

An example: imagine a dataset with a rare cell type that comes only from 1 sample. Selecting all cells from that sample will show you the proportion of cell types in that sample. But with this second number, you can see that this rare cell type is found only in this sample.

During our exploration of datasets with cellbrowser, I found that I want to see the second value in the interface too, and

[maximilianh]

This change is great, I totally understand the use case and the code looks great. I should have implemented it right away like this, no idea why I never did.

The only problem is "of it"...

How about: "of all cells with this value" ?

On Tue, Jan 5, 2021 at 7:10 PM Nikolay Markov notifications@github.com wrote:

Yes, you're right, in the image above it says that 78% of selected cells have the value “Cortex”, and those 78% constitute 37.7% of all cells with the value “Cortex”.

An example: imagine a dataset with a rare cell type that comes only from 1 sample. Selecting all cells from that sample will show you the proportion of cell types in that sample. But with this second number, you can see that this rare cell type is found only in this sample.

During our exploration of datasets with cellbrowser, I found that I want to see the second value in the interface too, and

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/205#issuecomment-754805404, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TN4NAC3W7LH6XAXBXDSYNIX3ANCNFSM4VNYFRIA .

[mxposed]

It's very clear, I like it and committed the change

[maximilianh]

Great! Thanks!