search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

Sanitises initial underscores in field names #209

Closed pcm32 closed 3 years ago

pcm32 commented 3 years ago

Aims to deal with #208

pcm32 commented 3 years ago

Would it be possible to get a release after this is merged @maximilianh ? I have tested that with this fix our dataset works.

maximilianh commented 3 years ago

Oh interesting. this has never come up before. Thanks!

nomadscientist commented 3 years ago

Should this have fixed the UCSC browser issue? I'm using this: (Galaxy Version 0.7.10+galaxy0). Still no luck...

maximilianh commented 3 years ago

We have not released yet, sorry.

On Thu, Mar 25, 2021 at 1:18 PM Wendi Bacon @.***> wrote:

Should this have fixed the UCSC browser issue? I'm using this: (Galaxy Version 0.7.10+galaxy0). Still no luck...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/209#issuecomment-806632965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TKSWS3RC73DMUYP2T3TFMSY3ANCNFSM4ZNA43DQ .

maximilianh commented 3 years ago

The reason is an open bug in the violin plot display

On Thu, Mar 25, 2021 at 2:23 PM Maximilian Haeussler @.***> wrote:

We have not released yet, sorry.

On Thu, Mar 25, 2021 at 1:18 PM Wendi Bacon @.***> wrote:

Should this have fixed the UCSC browser issue? I'm using this: (Galaxy Version 0.7.10+galaxy0). Still no luck...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/209#issuecomment-806632965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TKSWS3RC73DMUYP2T3TFMSY3ANCNFSM4ZNA43DQ .

pcm32 commented 3 years ago

Hi @maximilianh, any chance for a release soon that includes this? Thanks!

maximilianh commented 3 years ago

Hi Pablo, another bug came up. I'm trying to get everything now, but just in case: Would it be OK to do just a pip release? How important is the violin plot feature for you?

On Tue, Apr 6, 2021 at 12:29 PM Pablo Moreno @.***> wrote:

Hi @maximilianh https://github.com/maximilianh, any chance for a release soon that includes this? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/209#issuecomment-814012112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TIHKWSA6FVZXAGXAZLTHLPCPANCNFSM4ZNA43DQ .

pcm32 commented 3 years ago

For us a pip release is fine, since that should trigger the bioconda auto bump. @nomadscientist is the violin plot bug relevant to what you need to show? Could you point us @maximilianh to a description of this bug to understand whether we can live without it or not? Thanks!

matthewspeir commented 3 years ago

@pcm32 Bug:

  1. Go to our dev site: https://cells-test.gi.ucsc.edu/?ds=cortex-dev&gene=HES1 (coloring a plot by a gene)
  2. Switch cursor to rectangle select
  3. Select some cells
  4. Notice that violin plot below legend doesn't appear

Compare this behavior with our main site: https://cells.ucsc.edu/?ds=cortex-dev&gene=HES1.

maximilianh commented 3 years ago

OK, the violin thing is fixed. Matt, can we live with the labels bug for now? Or is that essential, too?

On Mon, Apr 12, 2021 at 7:03 PM Matt Speir @.***> wrote:

@pcm32 https://github.com/pcm32 Bug:

  1. Go to our dev site: https://cells-test.gi.ucsc.edu/?ds=cortex-dev&gene=HES1 (coloring a plot by a gene)
  2. Switch cursor to rectangle select
  3. Select some cells
  4. Notice that violin plot below legend doesn't appear

Compare this behavior with our main site: https://cells.ucsc.edu/?ds=cortex-dev&gene=HES1.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/pull/209#issuecomment-817974795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TOQRUNTZNPPTNXFNH3TIMRVTANCNFSM4ZNA43DQ .

matthewspeir commented 3 years ago

No, I think we're good to go.