search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

Longer/adaptable length drop down needed for layouts #214

Closed pcm32 closed 3 years ago

pcm32 commented 3 years ago

Visualising one of our Single Cell Expression Atlas AnnData's works very nicely with the multiple tSNEs and UMAPs that we are embedding currently, but the layout drop down could be wider on need if the names are long:

image

Thanks!

pcm32 commented 3 years ago

Please try with http://ftp.ebi.ac.uk/pub/databases/microarray/data/atlas/sc_experiments/E-MTAB-6077/E-MTAB-6077.project.h5ad (that is a lightweight one, every experiment has an AnnData).

maximilianh commented 3 years ago

Making user interfaces work for any length of input strings is very tricky. @Matthew Speir @.***> May have ideas on the optimal length here, I could add a few characters, but in general, I don't want to make this dropdown very long. It has served us well so far.

On Fri, Apr 16, 2021 at 12:51 PM Pablo Moreno @.***> wrote:

Please try with http://ftp.ebi.ac.uk/pub/databases/microarray/data/atlas/sc_experiments/E-MTAB-6077/E-MTAB-6077.project.h5ad (that is a lightweight one, every experiment has an AnnData).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/214#issuecomment-821091947, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TNDSCWCPKVDR37WGBTTJAJEJANCNFSM43BJQRVQ .

maximilianh commented 3 years ago

I'm tempted to close this. You could easily shorten your labels, right?

pcm32 commented 3 years ago

I'm not sure, we are a bit bound to include the words UMAP and neighbours, which make most of the length... couldn't the drop down be made variable width based on the number of characters? So maybe it grows only when you have above n characters?

maximilianh commented 3 years ago

Oh, you're right! There is actually code that was supposed to make it larger. Didn't work, not even for our datasets. I tried to change it now, wide enough? https://cells-test.gi.ucsc.edu/?ds=cortex-dev

On Mon, Apr 19, 2021 at 2:58 PM Pablo Moreno @.***> wrote:

I'm not sure, we are a bit bound to include the words UMAP and neighbours, which make most of the length... couldn't the drop down be made variable width based on the number of characters? So maybe it grows only when you have above n characters?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/214#issuecomment-822446115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TIH2AJYJIOKJQAMUT3TJQSIPANCNFSM43BJQRVQ .

pcm32 commented 3 years ago

I would presume that that should do.

On 19 Apr 2021, at 14:23, Maximilian Haeussler @.***> wrote:

Oh, you're right! There is actually code that was supposed to make it larger. Didn't work, not even for our datasets. I tried to change it now, wide enough? https://cells-test.gi.ucsc.edu/?ds=cortex-dev

On Mon, Apr 19, 2021 at 2:58 PM Pablo Moreno @.***> wrote:

I'm not sure, we are a bit bound to include the words UMAP and neighbours, which make most of the length... couldn't the drop down be made variable width based on the number of characters? So maybe it grows only when you have above n characters?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/214#issuecomment-822446115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TIH2AJYJIOKJQAMUT3TJQSIPANCNFSM43BJQRVQ .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/214#issuecomment-822463161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACZ6XRUVDPWFYFG6GMOOZLTJQVFTANCNFSM43BJQRVQ.

maximilianh commented 3 years ago

great.

matthewspeir commented 3 years ago

Hmm, does hovering over the layout name in the list display the full name? Would that be an acceptable compromise? While I haven't run into this with layout names, I have run into it with the collection dropdown, e.g. https://cells.ucsc.edu/?ds=covid19atlas+c19a-miller20. You can see that some of the dataset labels are cut-off.

maximilianh commented 3 years ago

The "chosen" dropdown box that I use unfortunately doesn't have this feature out of the box. I could add it, but just extending the box was the easiest solution. Clearly, we've run into this before, which why I tried to make it larger, but I did it the wrong way so the large size never made it out.

On Mon, Apr 19, 2021 at 4:37 PM Matt Speir @.***> wrote:

Hmm, does hovering over the layout name in the list display the full name? Would that be an acceptable compromise? While I haven't run into this with layout names, I have run into it with the collection dropdown, e.g. https://cells.ucsc.edu/?ds=covid19atlas+c19a-miller20. You can see that some of the dataset labels are cut-off.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/214#issuecomment-822517723, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACL4TNH3KPPF5XHU2KRA3TTJQ52TANCNFSM43BJQRVQ .