search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
102 stars 40 forks source link

stop() instead of error() in the cellbrowser.R script? #248

Closed tomsing1 closed 2 years ago

tomsing1 commented 2 years ago

I noticed the use of the error() command here and in another line of this script. I ran into a condition where this part of the code was called and got:

could not find function "error"

Perhaps that should be stop() instead?

https://github.com/maximilianh/cellBrowser/blob/d0e83c6bd645729564d1a847535f78d922ca9caa/src/cbPyLib/cellbrowser/R/cellbrowser.R#L113

maximilianh commented 2 years ago

Oops! Many thanks! I've changed this now. I guess we have never run into this special case here while using the code.

While at it, I'm also committing a code change that removes the .tsv.gz support for the very big matrices that exceed the R limits and always fall back to .mtx.gz export now. Probably I should always write .mtx.gz by default...?

Thanks for this suggestion and please don't hesitate to get back to us if you find similar things.