search

maximilianh / cellBrowser

main repo: https://github.com/ucscGenomeBrowser/cellBrowser/ - Python pipeline and Javascript scatter plot library for single-cell datasets, http://cellbrowser.rtfd.org
https://github.com/ucscGenomeBrowser/cellBrowser/
GNU General Public License v3.0
104 stars 40 forks source link

P-value for marker genes gets rounded to 4 decimal places #60

Closed mxposed closed 5 years ago

mxposed commented 5 years ago

It would be better to preserve the original value from markers gene file, and display it to the user in the exponent format (like 1.220254e-15)

maximilianh commented 5 years ago

Funny I found this comment in the code where it's rounded:

// four digits ought to be enough for everyone

Should be fixed now, I've simply replaced the formatting with toPrecision(4). This will switch to scientific exponent notation with four digits.

On Sun, Jan 13, 2019 at 1:31 PM Nikolay Markov notifications@github.com wrote:

It would be better to preserve the original value from markers gene file, and display it to the user in the exponent format (like 1.220254e-15)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/cellBrowser/issues/60, or mute the thread https://github.com/notifications/unsubscribe-auth/AAS-Tdp13dEJelOn-rGWCv3i5wx4GhIXks5vCycNgaJpZM4Z9JO6 .