search

maximilianh / crisporPaper

Code for the CRISPOR article, all data and code to create figures and analysis
41 stars 20 forks source link

plotGcOtRatio.py is giving incorrect offtarget/ontarget ratio #1

Open asgarhussain opened 5 years ago

asgarhussain commented 5 years ago

Hi, Script is calculating off-target frequency correctly but it is not able to plot ratio correctly. Can you check this ?

maximilianh commented 5 years ago

Hi, Can you give me a more detailed description of the problem?

Also, can I ask why you're using this at all? It's a use-one-time script, for the paper. If you're able to read the script, you can probably easily fix this yourself. No one else will ever use this script in the future.

I usually fix crispor-related problems, but I've never used the plotting scripts again since the publication of the paper.

On Thu, Aug 9, 2018 at 8:26 AM, asgarhussain notifications@github.com wrote:

Hi, Script is calculation off-target frequency correctly but it is not able to plot ratio correctly. Can you check this ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maximilianh/crisporPaper/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAS-TQm6baRvBKxj4NQf6BpcmniOPQQQks5uO-QpgaJpZM4V1Ldk .

asgarhussain commented 5 years ago

I have fixed it. I wanted to use the script for our in-house data.

maximilianh commented 5 years ago

Ah OK. I see. You may also want to plot the efficiency scores (see https://github.com/maximilianh/crisporWebsite/blob/master/crisporEffScores.py) and/or use the CFD off-target score when looking at off-targets. Keep in mind that depending on your quantification, the % cleavage of off-targets may not be very reproducible, but NGS is usually fine.

On Fri, Aug 10, 2018 at 12:26 PM, asgarhussain notifications@github.com wrote:

I have fixed it. I wanted to use the script for our in-house data.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/maximilianh/crisporPaper/issues/1#issuecomment-412055391, or mute the thread https://github.com/notifications/unsubscribe-auth/AAS-TQt4Hymy-3TiZQDCaa6xKjyJIBwHks5uPW4AgaJpZM4V1Ldk .