search

maximilien / softlayer-go

A SoftLayer client API written in Golang
Apache License 2.0
18 stars 24 forks source link

Place block storage (performance ISCSI) order by indicating iops, disksize, hourlybillingflag #113

Closed jianqiu closed 8 years ago

jianqiu commented 8 years ago

This PR is trying to fix the issue 110

maximilien commented 8 years ago

Overall looks good @jianqiu, however, see my comments. I think this needs to be in CPI as utility unless the answer to my question is yes and you can point me to SL docs online. Thx

maximilien commented 8 years ago

Ok @jianqiu what about this proposed compromise:

  1. We keep it here as you want since, as you argue, it's an advance use of the SL API
  2. We, however, move all non-official SL APIs functions into a new utils package

That way we do not break the main design point of SL go to reflect the SL APIs 1-to-1 as much as possible, yet allow useful "extensions" like this one to exist into utilities. We could even in time create things like utils/storage and utils/virtual_guest etc.

What do you think JQ?

jianqiu commented 8 years ago

@maximilien @mattcui Max, I already updated the PR and removed all special methods, made just 1-to-1 mapping. And the PR had resolved issue 110, Simyung Yang already closed it. Thanks!

maximilien commented 8 years ago

Merging for purposes of solving issue #110 but please address my comment, remove the methods we are not implementing rather than returning some special errors.