search

maximilien / softlayer-go

A SoftLayer client API written in Golang
Apache License 2.0
17 stars 24 forks source link

Allow users to choose to use internal or external api endpoint. #118

Closed mattcui closed 8 years ago

mattcui commented 8 years ago

We noticed that the internal softlayer api endpoint (api.service.softlayer.com) is more stable than the external most of the time. Currently, the softlayer-go only uses the external api endpoint, I think there should give users a chance to choose to use the internal or the external endpoint. A solution is that softlayer-go can set the endpoint reading from a system variable like "SL_API_ENDPOINT_URL", the default value should still be the external endpoint we are using currently. @maximilien What do you think? Thanks.

maximilien commented 8 years ago

Sounds good. Send a PR, should not be hard to do.

mattcui commented 8 years ago

@maximilien submitted PR 119 for review and merge. Thanks.

maximilien commented 8 years ago

Closing since PR #119 is addressing. Cheers 👍