Added retry code for i/o time out problem

maximilien / softlayer-go

A SoftLayer client API written in Golang

Apache License 2.0

17 stars 24 forks source link

Added retry code for i/o time out problem #122

Closed mattcui closed 8 years ago

mattcui commented 8 years ago

@maximilien This PR is for addressing issue 121, I already did some test through bosh-softlayer-go. Please review the code change. Thanks.

maximilien commented 8 years ago

@mattcui please address comment and please add unit tests verifying retries and environment variables to tune behavior. Thx

mattcui commented 8 years ago

@maximilien Addressed your comments about setting count and wait time in environment variables. I found there is empty in http_client_test.go, I would like to help write unit tests there, but I hope to complete some other urgent eCPI/Softlayer-go bugs/features first. Is it OK? Thanks.

mattcui commented 8 years ago

@maximilien It's ready for review. Thanks.

maximilien commented 8 years ago

There are no tests. Rejecting. Please add some tests (unit and at least one integration) and I will review again. Thx.