maximilienGilet / notification-bundle

A simple Symfony bundle to notify user
https://packagist.org/packages/mgilet/notification-bundle
MIT License
107 stars 58 forks source link

Upgrade / make compatible with Symfony 5.x #79

Closed parijke closed 3 years ago

parijke commented 4 years ago

I currently tried to use this bundle in a Symfony 5.1.3 but I ran into a lot of errors.

Any plans to update this to 5.x?

maximilienGilet commented 3 years ago

Hi @parijke, I'm not using this bundle anymore so I don't know what are the errors. If someone could make a PR with changes for 5.x compatibility I would gladly accept it 👍

murilozilli commented 3 years ago

This is the error message i get trying to install it

!!  ArgumentCountError {#5113
!!    #message: "Too few arguments to function Symfony\Component\Config\Definition\Builder\TreeBuilder::__construct(), 0 passed in /home/murilo/desenvolvimento/easy-admin-demo/vendor/mgilet/notification-bundle/DependencyInjection/Configuration.php on line 20 and at least 1 expected"
!!    #code: 0
!!    #file: "./vendor/symfony/config/Definition/Builder/TreeBuilder.php"
!!    #line: 26
!!    trace: {
!!      ./vendor/symfony/config/Definition/Builder/TreeBuilder.php:26 { …}
!!      ./vendor/mgilet/notification-bundle/DependencyInjection/Configuration.php:20 { …}
!!      ./vendor/symfony/config/Definition/Processor.php:50 { …}
!!      ./vendor/symfony/dependency-injection/Extension/Extension.php:111 { …}
!!      ./vendor/mgilet/notification-bundle/DependencyInjection/MgiletNotificationExtension.php:31 { …}
!!      ./vendor/symfony/dependency-injection/Compiler/MergeExtensionConfigurationPass.php:76 { …}
!!      ./vendor/symfony/http-kernel/DependencyInjection/MergeExtensionConfigurationPass.php:39 { …}
!!      ./vendor/symfony/dependency-injection/Compiler/Compiler.php:91 { …}
!!      ./vendor/symfony/dependency-injection/ContainerBuilder.php:736 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:533 { …}
!!      ./vendor/symfony/http-kernel/Kernel.php:131 { …}
!!      ./vendor/symfony/framework-bundle/Console/Application.php:168 { …}
!!      ./vendor/symfony/framework-bundle/Console/Application.php:74 { …}
!!      ./vendor/symfony/console/Application.php:140 { …}
!!      ./bin/console:43 {
!!        › $application = new Application($kernel);
!!        › $application->run($input);
!!        › 
!!        arguments: {
!!          $input: Symfony\Component\Console\Input\ArgvInput {#3 …}
!!        }
!!      }
!!    }
!!  }
!!  2021-04-27T09:29:40+10:00 [critical] Uncaught Error: Too few arguments to function Symfony\Component\Config\Definition\Builder\TreeBuilder::__construct(), 0 passed in /home/murilo/desenvolvimento/easy-admin-demo/vendor/mgilet/notification-bundle/DependencyInjection/Configuration.php on line 20 and at least 1 expected