search

maximiseuk / onlinestudytools

A repository for the online study tools as part of the MAXIMISE revision service, found at:
https://maximise.org.uk
1 stars 0 forks source link

Tools #39

Closed isaac-holt closed 4 years ago

Joseph-Rance commented 4 years ago

@KashParty probs should have said this before I accepted, but i think there may be a problem

Joseph-Rance commented 4 years ago

This might be stupid, but should agenda have stuff in it by default? I feel like he added this in debugging

Joseph-Rance commented 4 years ago

added to agenda.json:

[
  {
    "subject": "Maths",
    "desc": "Do surds hw",
    "date": "Fri Jan 10 2020 13:27:07 GMT+0000 (Greenwich Mean Time)",
    "time": false
  },
  {
    "subject": "English",
    "desc": "Retest",
    "date": "Thu Jan 04 2020 13:27:07 GMT+0000 (Greenwich Mean Time)",
    "time": "All Day"
  },
  {
    "subject": "Physics",
    "desc": "Prove one-electron-universe",
    "date": "Wed Jan 08 2020 13:27:07 GMT+0000 (Greenwich Mean Time)",
    "time": "All Day"
  },
  {
    "subject": "Biology",
    "desc": "Revise for test",
    "date": "Thu Jan 02 2020 13:27:07 GMT+0000 (Greenwich Mean Time)",
    "time": false
  },
  {
    "subject": "Geography",
    "desc": "Coasts hw",
    "date": "Thu Jan 02 2020 13:27:07 GMT+0000 (Greenwich Mean Time)",
    "time": false
  },
  {
    "subject": "Maths",
    "desc": "Read chapter on graph of a^x and log a (x)",
    "date": "Sat Jan 04 2020 13:27:07 GMT+0000 (Greenwich Mean Time)",
    "time": "All Day"
  }
]
Joseph-Rance commented 4 years ago

I'll let @maximiseuk review this because I'm not sure about it

maximiseuk commented 4 years ago

I think it's pretty obvious that that's just for debugging and probably needs to be removed. I'm not sure if the user will ever see that though because it's probably replaced with the agenda fetched from the database.

Joseph-Rance commented 4 years ago

ok i wasn't sure as I have had little involvement with the js. I'll change them for him

Joseph-Rance commented 4 years ago

@maximiseuk I think i've fixed the issue but I'm not 100% sure so I'll leave this one for u to review

Joseph-Rance commented 4 years ago

Also, it has a similar thing in master so it obvs. doesn't really matter but I do think it is better this way regardless as commits to master should not really have debugging stuff in them