maximkoretskiy / postcss-initial

PostCSS plugin to fallback initial keyword
MIT License
187 stars 11 forks source link

multi value initial replace #17

Closed johnbender closed 8 years ago

johnbender commented 8 years ago

This PR addresses #16

It might be that the declarations JSON should be augmented with some flag to permit multivalued replacements. For example, if a user accidentally writes animation: initial initial; this implementation will output animation: none 0s ease 0s 1 normal none running none 0s ease 0s 1 normal none running;.

The flag "mutilvalued": true could act as a white list for properties that support many initial values.

In any event it's a start :)

johnbender commented 8 years ago

Sigh. Sorry about the extra commits. I'm happy to close and resubmit with a cleaner history.

maximkoretskiy commented 8 years ago

I can squash it

Sent from my iPhone

On 08 Apr 2016, at 10:39, John Bender notifications@github.com wrote:

Sigh. Sorry about the extra commits. I'm happy to close and resubmit with a cleaner history.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

maximkoretskiy commented 8 years ago

Sorry, I meant that You can to squash these commits. Here is manual https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/

johnbender commented 8 years ago

Yep, I've been here before 👍

maximkoretskiy commented 8 years ago

Can You add a test for this case? It will be better if You will use the same fixture for it.

div {
  background-repeat: initial no-repeat;
} 
johnbender commented 8 years ago

Added :)

johnbender commented 8 years ago

Great!