search

maximkou / grav-plugin-videoembed

Embed video support plugin for Grav CMS
http://maximkou.github.io/grav-plugin-videoembed
MIT License
4 stars 5 forks source link

Fixed empty content issue in Grav v0.9.15 #13

Closed Sommerregen closed 9 years ago

Sommerregen commented 9 years ago

Today I updated Grav to v0.9.15 with all its plugins including yours (VideoEmbed v1.4.0). It turned out that your plugin was causing a "Page Not Found" error, because it emptied all content on output. However, I found the problem: Due to a recent change in Grav core in the Pages.php $page->content() returns now empty on the onPageProcessed event. Maybe this is a bug in Grav core, but nevertheless using the onPageContentProcessed call is much safer and faster, since it is only called, when content has changed and not on every page call.

BTW: If this is abandoned and if you are seekng maintainer, I can continue your plugin as you wish.

Sommerregen commented 9 years ago

Since VideoEmbed evolved quickly and I released an official successor of Grav VideoEmbed plugin, I will close this PR now.