search

maximkulkin / esp-homekit-demo

Demo of Apple HomeKit accessory server library
MIT License
805 stars 233 forks source link

esp32 button example not compiling, issue with wifi init #334

Closed DBabs1 closed 3 years ago

DBabs1 commented 4 years ago

Hey, I can't get the button example to compile without issue. If I copy the wifi init of the esp32/led example it will compile and load in homekit but the button won't work correctly. the esp32/led compiles fine here.

here's the 2 errors, any ideas on what i can do to make this work?:

/Users/Derek/esp/esp-homekit-demo/examples/esp32/button/main/main.c:32:21: error: implicit declaration of function 'esp_netif_init'; did you mean 'esp_wifi_init'? [-Werror=implicit-function-declaration] ESP_ERROR_CHECK(esp_netif_init()); ^~~~~~ /Users/Derek/esp/esp-idf/components/esp_common/include/esp_err.h:118:31: note: in definition of macro 'ESP_ERROR_CHECK' esp_err_t __err_rc = (x); \ ^ /Users/Derek/esp/esp-homekit-demo/examples/esp32/button/main/main.c:35:5: error: implicit declaration of function 'esp_netif_create_default_wifi_sta' [-Werror=implicit-function-declaration] esp_netif_create_default_wifi_sta();

yz88 commented 4 years ago

Hi, first of all thanks for providing a button example for esp32. I'm facing the same issue with a fresh esp-idf toolchain v3.3.1 on Windows and unchanged code from the button example.

CC examples/esp32/button/build/lwip/lwip/src/netif/lowpan6.o
CC examples/esp32/button/build/lwip/lwip/src/netif/ethernet.o
CC examples/esp32/button/build/lwip/lwip/src/netif/slipif.o
CC examples/esp32/button/build/lwip/port/esp32/vfs_lwip.o
CC examples/esp32/button/build/lwip/port/esp32/freertos/sys_arch.o
CC examples/esp32/button/build/lwip/port/esp32/netif/ethernetif.o
CC examples/esp32/button/build/lwip/port/esp32/netif/dhcp_state.o
CC examples/esp32/button/build/lwip/port/esp32/netif/wlanif.o
CC examples/esp32/button/build/lwip/port/esp32/debug/lwip_debug.o
AR examples/esp32/button/build/lwip/liblwip.a
make[1]: Verzeichnis „/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/build/lwip“ wird verlassen
make[1]: Verzeichnis „/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/build/main“ wird betreten
CC examples/esp32/button/build/main/main.o
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c: In function 'event_handler':
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:22:23: error: 'WIFI_EVENT' undeclared (first use in this function)
     if (event_base == WIFI_EVENT && (event_id == WIFI_EVENT_STA_START || event_id == WIFI_EVENT_STA_DISCONNECTED)) {
                       ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:22:23: note: each undeclared identifier is reported only once for each function it appears in
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:22:50: error: 'WIFI_EVENT_STA_START' undeclared (first use in this function)
     if (event_base == WIFI_EVENT && (event_id == WIFI_EVENT_STA_START || event_id == WIFI_EVENT_STA_DISCONNECTED)) {
                                                  ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:22:86: error: 'WIFI_EVENT_STA_DISCONNECTED' undeclared (first use in this function)
     if (event_base == WIFI_EVENT && (event_id == WIFI_EVENT_STA_START || event_id == WIFI_EVENT_STA_DISCONNECTED)) {
                                                                                      ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:25:30: error: 'IP_EVENT' undeclared (first use in this function)
     } else if (event_base == IP_EVENT && event_id == IP_EVENT_STA_GOT_IP) {
                              ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:25:54: error: 'IP_EVENT_STA_GOT_IP' undeclared (first use in this function)
     } else if (event_base == IP_EVENT && event_id == IP_EVENT_STA_GOT_IP) {
                                                      ^
In file included from C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-idf/components/esp32/include/esp_wifi.h:62:0,
                 from C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:2:
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c: In function 'wifi_init':
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:32:21: error: implicit declaration of function 'esp_netif_init' [-Werror=implicit-function-declaration]
     ESP_ERROR_CHECK(esp_netif_init());
                     ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-idf/components/esp32/include/esp_err.h:117:31: note: in definition of macro 'ESP_ERROR_CHECK'
         esp_err_t __err_rc = (x);                                       \
                               ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:35:5: error: implicit declaration of function 'esp_netif_create_default_wifi_sta' [-Werror=implicit-function-declaration]
     esp_netif_create_default_wifi_sta();
     ^
In file included from C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-idf/components/esp32/include/esp_wifi.h:62:0,
                 from C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:2:
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:37:48: error: 'WIFI_EVENT' undeclared (first use in this function)
     ESP_ERROR_CHECK(esp_event_handler_register(WIFI_EVENT, ESP_EVENT_ANY_ID, &event_handler, NULL));
                                                ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-idf/components/esp32/include/esp_err.h:117:31: note: in definition of macro 'ESP_ERROR_CHECK'
         esp_err_t __err_rc = (x);                                       \
                               ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:38:48: error: 'IP_EVENT' undeclared (first use in this function)
     ESP_ERROR_CHECK(esp_event_handler_register(IP_EVENT, IP_EVENT_STA_GOT_IP, &event_handler, NULL));
                                                ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-idf/components/esp32/include/esp_err.h:117:31: note: in definition of macro 'ESP_ERROR_CHECK'
         esp_err_t __err_rc = (x);                                       \
                               ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:38:58: error: 'IP_EVENT_STA_GOT_IP' undeclared (first use in this function)
     ESP_ERROR_CHECK(esp_event_handler_register(IP_EVENT, IP_EVENT_STA_GOT_IP, &event_handler, NULL));
                                                          ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-idf/components/esp32/include/esp_err.h:117:31: note: in definition of macro 'ESP_ERROR_CHECK'
         esp_err_t __err_rc = (x);                                       \
                               ^
In file included from C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/components/common/homekit/include/homekit/homekit.h:4:0,
                 from C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:13:
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c: At top level:
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:113:19: warning: initialized field overwritten [-Woverride-init]
         .category=homekit_accessory_category_programmable_switch,
                   ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/components/common/homekit/include/homekit/types.h:243:11: note: in definition of macro 'HOMEKIT_ACCESSORY'
         ##__VA_ARGS__ \
           ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:113:19: note: (near initialization for '(anonymous).category')
         .category=homekit_accessory_category_programmable_switch,
                   ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/components/common/homekit/include/homekit/types.h:243:11: note: in definition of macro 'HOMEKIT_ACCESSORY'
         ##__VA_ARGS__ \
           ^
In file included from C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:11:0:
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c: In function 'app_main':
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:159:29: warning: initialized field overwritten [-Woverride-init]
         .max_repeat_presses=2,
                             ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/components/common/button/button.h:31:5: note: in definition of macro 'BUTTON_CONFIG'
     __VA_ARGS__ \
     ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/main/main.c:159:29: note: (near initialization for '(anonymous).max_repeat_presses')
         .max_repeat_presses=2,
                             ^
C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/components/common/button/button.h:31:5: note: in definition of macro 'BUTTON_CONFIG'
     __VA_ARGS__ \
     ^
cc1.exe: some warnings being treated as errors
make[1]: *** [/home/Holger/esp-idf-v3.3.1/esp-idf/make/component_wrapper.mk:290: main.o] Fehler 1
make[1]: Verzeichnis „/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button/build/main“ wird verlassen
make: *** [C:/Users/wiege/Documents/esp32-dev-env/msys32/home/Holger/esp-idf-v3.3.1/esp-idf/make/project.mk:552: component-main-build] Fehler 2
make: Verzeichnis „/home/Holger/esp-idf-v3.3.1/esp-homekit-demo/examples/esp32/button“ wird verlassen
rillhu commented 4 years ago

Hey, I can't get the button example to compile without issue. If I copy the wifi init of the esp32/led example it will compile and load in homekit but the button won't work correctly. the esp32/led compiles fine here.

here's the 2 errors, any ideas on what i can do to make this work?:

/Users/Derek/esp/esp-homekit-demo/examples/esp32/button/main/main.c:32:21: error: implicit declaration of function 'esp_netif_init'; did you mean 'esp_wifi_init'? [-Werror=implicit-function-declaration] ESP_ERROR_CHECK(esp_netif_init()); ^~~~~~ /Users/Derek/esp/esp-idf/components/esp_common/include/esp_err.h:118:31: note: in definition of macro 'ESP_ERROR_CHECK' esp_err_t __err_rc = (x); ^ /Users/Derek/esp/esp-homekit-demo/examples/esp32/button/main/main.c:35:5: error: implicit declaration of function 'esp_netif_create_default_wifi_sta' [-Werror=implicit-function-declaration] esp_netif_create_default_wifi_sta();

Hi, This esp32 example is a little old-fashioned, you could refer to my repository to rewrite the mian.c.(although I used another homekit library from younghyunjo, you could still find useful style of main.c from my repo). You can find my main.c here.

kunjal83 commented 4 years ago

Use the current example and add the below as marked to compile successfully. 

 #include <freertos/FreeRTOS.h>
+#include <freertos/event_groups.h>
 #include <freertos/task.h>

 #define EXAMPLE_ESP_WIFI_SSID      "xxxxx"
 #define EXAMPLE_ESP_WIFI_PASS      "xxxxx"
 #define EXAMPLE_ESP_MAXIMUM_RETRY  CONFIG_ESP_MAXIMUM_RETRY

Replace exiting method for wifi_init with below: 

static void wifi_init() {
    s_wifi_event_group = xEventGroupCreate();
    tcpip_adapter_init();
    ESP_ERROR_CHECK(esp_event_loop_init(event_handler, NULL) );

    wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();
    ESP_ERROR_CHECK(esp_wifi_init(&cfg));
    wifi_config_t wifi_config = {
        .sta = {
            .ssid = EXAMPLE_ESP_WIFI_SSID,
            .password = EXAMPLE_ESP_WIFI_PASS
        },
    };

    ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_STA) );
    ESP_ERROR_CHECK(esp_wifi_set_config(ESP_IF_WIFI_STA, &wifi_config) );
    ESP_ERROR_CHECK(esp_wifi_start() );

    ESP_LOGI("Tag", "wifi_init_sta finished.");
    ESP_LOGI("Tag", "connect to ap SSID:%s password:%s",
             EXAMPLE_ESP_WIFI_SSID, EXAMPLE_ESP_WIFI_PASS);

}
maximkulkin commented 4 years ago

@DBabs1 I've re-checked button example and it compiles OK with latest ESP-IDF with both make and idf.py build

@kunjal83 Not sure where you get this best practices from, but your code is a bit outdated.

DBabs1 commented 4 years ago

Thanks

kunjal83 commented 4 years ago

Yes, i know i am using the older piece of code. I just checked again with the ESP-IDF v4.0.1. i still get error. Could be due to version: 

error: implicit declaration of function 'esp_netif_init'; did you mean 'esp_wifi_init'? [-Werror=implicit-function-declaration]
     ESP_ERROR_CHECK(esp_netif_init());
maximkulkin commented 4 years ago

Try using latest master

kunjal83 commented 4 years ago

@maximkulkin , yes works with latest master.