search

maximkulkin / esp-homekit

Apple HomeKit accessory server library for ESP-OPEN-RTOS
MIT License
1.1k stars 168 forks source link

Pair setup issues due to mDNS fix #123

Closed d4rkmen closed 3 years ago

d4rkmen commented 4 years ago

Another mDNS implementation for RTOS SDK and mDNS configuration logic changed

maximkulkin commented 4 years ago

What is the rationale behind sockets setup fix?

maximkulkin commented 4 years ago

Why do you need a new “discoverable” variable which is just an inverse of “paired” variable?

d4rkmen commented 4 years ago

Oops. Sockets issue is not related to pairing. It should be separate PR. The problem is: when controller closes the connection at session end (this is normal) accessory still tries to read data from connection (due to keepalive settings?)

d4rkmen commented 4 years ago

Why do you need a new “discoverable” variable which is just an inverse of “paired” variable?

Otherwise it will call mdns config every request, not once

maximkulkin commented 4 years ago

Oops. Sockets issue is not related to pairing. It should be separate PR. The problem is: when controller closes the connection at session end (this is normal) accessory still tries to read data from connection (due to keepalive settings?)

How do you know this is actually the case and you’re not making this up? How do you test? How do you know that this particular changes fix the problem?

d4rkmen commented 4 years ago

How do you know this is actually the case and you’re not making this up?

After I detected errors in logs (all the time) I have added some traces and found the error appers at the session end (phine closes connection). Then checked the HomeKitADK for socets setup as an instance.

How do you test?

Tested on your samples

How do you know that this particular changes fix the problem?

After 24h testing - there was no errors in the log. This particular issue is gone, but not sure is there new ones (so far) As we all can see, thing works for one not 100% works for all